[SYCL][Docs] Add sycl_ext_oneapi_inter_process_communication #20018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
force-pushed
the
ext_oneapi_inter_process_communication
branch
from
cae8ee3 to
14415fe
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
force-pushed
the
ext_oneapi_inter_process_communication
branch
from
14415fe to
89f495c
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
steffenlarsen
force-pushed
the
ext_oneapi_inter_process_communication
branch
from
89f495c to
5f443ab
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
force-pushed
the
ext_oneapi_inter_process_communication
branch
from
5f443ab to
b7d2052
Compare
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
force-pushed
the
ext_oneapi_inter_process_communication
branch
from
b7d2052 to
07f4355
Compare
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
force-pushed
the
ext_oneapi_inter_process_communication
branch
from
07f4355 to
7364b75
Compare
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
This commit adds a new extension for inter-process communicable SYCL object handles. As part of the initial version of this extension, only inter-process communicable memory is exposed. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
force-pushed
the
ext_oneapi_inter_process_communication
branch
from
7364b75 to
eec1fe5
Compare
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vinser52
reviewed
Sep 15, 2025
| @@ -439,3 +440,10 @@ struct ur_mem_handle_t_ : ur::cuda::handle_base { | |||
| } | |||
| } | |||
| }; | |||
|
|
|||
| struct ur_exp_ipc_mem_handle_t_ { | |||
| umf_memory_pool_handle_t UMFPool; | |||
There was a problem hiding this comment.
Why do you need UMFPool to be part of the handle?
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vinser52
reviewed
Sep 15, 2025
Comment on lines
+29
to
+38
| #if defined(__linux__) | ||
| // UMF currently requires ptrace permissions to be set for the spawner. As | ||
| // such we need to set it until this limitation has been addressed. | ||
| // https://github.com/oneapi-src/unified-memory-framework/tree/main?tab=readme-ov-file#level-zero-memory-provider | ||
| if (Q.get_backend() == sycl::backend::ext_oneapi_level_zero && | ||
| prctl(PR_SET_PTRACER, getppid()) == -1) { | ||
| std::cout << "Failed to set ptracer permissions!" << std::endl; | ||
| return 1; | ||
| } | ||
| #endif // defined(__linux__) |
There was a problem hiding this comment.
we need to decide if it has to be an application responsibility to set the required permissions.
There was a problem hiding this comment.
Indeed. We could move this to the adapter. Seems too low-level as a requirement at user-level.
There was a problem hiding this comment.
yeah, but there might be security concerns
There was a problem hiding this comment.
When we designed IPC support in UMF, we agreed that it should be client's responsibility to change the security permissions. However, UMF is a low-level API, and it is acceptable at that level.
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new extension for inter-process communicable SYCL object handles. As part of the initial version of this extension, only inter-process communicable memory is exposed.